fix: add WETH on Optimism #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Shutt <pemulis@users.noreply.github.com>
Reinis-FRP
reviewed
Sep 12, 2022
UMIPs/umip-weth.md
Outdated
| @@ -0,0 +1,38 @@ | |||
| **UMIP #** - tbd | |||
|
|
|||
There was a problem hiding this comment.
Should this go in as a full UMIP or as a UPP to UMIP 10?
https://github.com/UMAprotocol/UMIPs/blob/master/UMIPs/umip-10.md
There was a problem hiding this comment.
It's traditionally a umip if it is a new currency like this. UPPs really only for contract parameter or final fee changes (we really shouldn't have a "UPP" imo since the onchain process is exactly the same and it just introduces confusion!)
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Reinis-FRP
previously approved these changes
Sep 13, 2022
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
smb2796
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Shutt pemulis@users.noreply.github.com
This UMIP will add the WETH token on Optimism as an approved collateral currency.
https://discourse.umaproject.org/t/add-weth-as-collateral-currency-on-optimism/1803